matriex / System_Extractor-WIN

Extractor_Windows
90 stars 37 forks source link

Oreo uses Brotli #6

Open ALTracer opened 6 years ago

ALTracer commented 6 years ago

Thank you for this very handy tool, it greatly accelerates OTA unpacking for diffs. I use your WIN and Linux versions (dualboot) pretty often, as Beyond Compare 4 is available on both. (I don't have enough time to forge pull requests now, absolutely overwhelmed with exams)

Except now that I'm into testing LineageOS-15.1 for arm64 rolex, the FS images are packed inside ext4fs, simg "sparse", AND Brotli on top (which is great, thanks Google!). Also Treble introduces two separate partitioins, /system and /vendor -- two images in the ROM.

Please add brotli hooks and distributable .exe /.elf to your (next) .zip releases and add vendor detection and unpacking. P.S. It would be nice to save __statfile.txt for quick efficient checks.

matriex commented 6 years ago

Added brotli. Added Unpacking. Done. All thanks to tsvietOK.

NotesOfReality commented 6 years ago

May I know why is this still opened ?

ALTracer commented 6 years ago

After merging the pull request Brotli is supported for system.new.dat, but there is no mention of vendor.new.dat (Treble). I can confirm, my ROMs are half unpacked automatically now. I might be able to craft another pull request for that, but .BAT scripting logic sometimes confuses me. These lines should be executed: bin\brotli -jd -o vendor.new.dat vendor.new.dat.br

REM Extracts .new.dat Oreo ROMs 
bin\python\sdat2img.py vendor.transfer.list vendor.new.dat vendor.img.ext4 
ren vendor.img.ext4 *.img 
bin\Imgextractor.exe vendor.img.img -i 
echo Press enter to delete temorary files 
pause 
del vendor.img.img 
del vendor.new.dat 
del vendor.transfer.list 
pause

Besides, we should remove temporary extraction stages as soon as they are no longer needed. Else the folder consumes 6-8 times more space than zip size.

NotesOfReality commented 6 years ago

I haven't thought about it, thanks for sharing it so that this projects always improves.