search

matrix-hacks / matrix-puppet-bridge

Facilitates implementation of double puppeted Matrix bridges
80 stars 28 forks source link

Support avatar to be buffer #59

Closed nr23730 closed 5 years ago

nr23730 commented 5 years ago

Solves #58.

I think Buffer is an appropriate alternative to URL. It works more like the uploading for images or attachments.

nr23730 commented 5 years ago

Apparently not. For me (Signal bridge, but should be same for all other bridges) the setGhostAvatar function is just called once at startup when I add all my contacts to the status room and after this only for single contacts when they update their profile (avatar, name, etc.).

twouters commented 5 years ago

In that case: nice!

@thomas-profitt just looking at the diff, this change seems fine. I'll give it a try on my setup to see if anything awful comes up.

twouters commented 5 years ago

fyi - been running with this patch for ~2 weeks and nothing broke so far.

thomas-profitt commented 5 years ago

Thanks for the contribution!

And @twouters, thanks again for testing.