matrix-hacks / matrix-puppet-skype

23 stars 12 forks source link

Messages from non-contact users are handled incorrectly #30

Closed esmekhov closed 4 years ago

esmekhov commented 4 years ago

When someone's present in the group chat, who isn't added to the list of contacts, their messages can't be processed by the bridge, causing an exception, as shown by skypebot.

poll: An error happened while processing the polled messages
  caused by ReferenceError: data is not defined
    at App.getThirdPartyUserDataById_noPromise (/home/esmekhov/matrix-puppet-skype/index.js:87:12)
    at App.getPayload (/home/esmekhov/matrix-puppet-skype/index.js:103:35)
    at App.handleSkypeMessage (/home/esmekhov/matrix-puppet-skype/index.js:109:24)
    (...omitted the rest of the stack trace)

I'll try to create a pull request fixing this shortly.