search

matrix-hacks / matrix-puppet-skype

23 stars 12 forks source link

Fix #30 - messages from non-contact users are handled incorrectly #31

Closed esmekhov closed 4 years ago

esmekhov commented 4 years ago

This fixes the exception issue, from what I see locally.

Unfortunately, there could be another issue, which I don't understand at the moment. For some reason created puppet users are not added to the room which causes the same problem - inability to see their messages. But this can be remedied by launching the bridge again.

esmekhov commented 4 years ago

I think I found the issue, but unfortunately testing has proved difficult since my newly created user has not experienced the same problem. I've bumped the version, because the code that uses provided avatar url has been updated with more cases and I think it handles the issue.

If there is any advice on how to handle testing this bridge (I assume e2e by sending requests at it and reading responses), it would be much appreciated.

nr23730 commented 4 years ago

Thanks a lot!