search

matrix-hacks / matrix-puppet-slack

puppet style slack bridge for matrix
47 stars 17 forks source link

Convert Slack's <!channel> to @room #32

Closed thomas-profitt closed 6 years ago

thomas-profitt commented 6 years ago

Currently, it gets parsed as a Slack tag and turned into "!channel", which does not notify by default in Matrix (or at least in Riot).

thomas-profitt commented 6 years ago

I also have this backported to master. I'll submit a PR for that branch if you're interested.

kfatehi commented 6 years ago

Hi Thomas — I am currently not involved with matrix (though I hope to be again soon) but I really appreciate all the high quality contributions you’ve been making to these bridges. Let me know if I can help in any way. I.e. granting write access to these repos. On Tue, Mar 20, 2018 at 2:11 PM thomas-profitt notifications@github.com wrote:

I also have this backported to master. I'll submit a PR for that branch if you're interested.

— You are receiving this because you are subscribed to this thread. Reply to this email directly, view it on GitHub https://github.com/matrix-hacks/matrix-puppet-slack/pull/32#issuecomment-374758054, or mute the thread https://github.com/notifications/unsubscribe-auth/AAKsyQRds9dUMhLVO6gqbhXjPpIvjBwtks5tgXBugaJpZM4SwpsT .

thomas-profitt commented 6 years ago

@kfatehi That explains why @-mentioning you in the Matrix Puppet Bridge room went nowhere :sweat_smile:

Happy to accept write-access/org invite.

kfatehi commented 6 years ago

Ah please accept my apologies for that. Even with knowledge of Matrix I find it difficult to keep abreast of all these communication platforms and have to dedicate huge effort again to re-wrangle them back into my control. I am looking forward to ripcord though https://cancel.fm/ripcord/ once the developer adds matrix support.

I will send you an invite to the org / grant write access later this evening. Thank you! On Thu, Mar 22, 2018 at 10:18 AM thomas-profitt notifications@github.com wrote:

@kfatehi https://github.com/kfatehi That explains why @-mentioning you in the Matrix Puppet Bridge room went nowhere 😅

Happy to accept write-access/org invite.

— You are receiving this because you were mentioned.

Reply to this email directly, view it on GitHub https://github.com/matrix-hacks/matrix-puppet-slack/pull/32#issuecomment-375387516, or mute the thread https://github.com/notifications/unsubscribe-auth/AAKsyYK-5kUwenvQDVJDo3aoCphaJcPBks5tg9zrgaJpZM4SwpsT .

thomas-profitt commented 6 years ago

See https://github.com/matrix-hacks/matrix-puppet-slack/issues/35 for why this isn't a complete solution.