search

matrix-hacks / matrix-puppet-slack

puppet style slack bridge for matrix
47 stars 17 forks source link

Our rooms are created able to be joined by anyone who knows the room ID #56

Closed thomas-profitt closed 5 years ago

thomas-profitt commented 5 years ago

Because data in the Slack channels is expected to be kept private, and the Slack channel IDs may or may not be considered private (I don't know), this is a significant concern.

I believe the develop_new branch which uses matrix-puppet-server and matrix-puppet-bridge develop doesn't have this problem, but the new architecture is still in-the-works, and until it becomes stable this will remain an issue.

(Even if the problem's cause and solution is in matrix-puppet-bridge, the library, the problem affects the application and should be reported here (too))

thomas-profitt commented 5 years ago

Fixed by matrix-puppet-slack 1.11.0 (by using matrix-puppet-bridge 1.17.0)!