matrix-io / matrix-creator-hal

Hardware Abstraction Layer for MATRIX Creator & MATRIX Voice
https://matrix-io.github.io/matrix-documentation/matrix-hal/overview/
GNU General Public License v3.0
70 stars 50 forks source link

Scale led values #1

Closed arhuaco closed 7 years ago

arhuaco commented 8 years ago

Hi Andrés and Kevin.

Could you normalize the scale of the LEDs somehow? This will make the everloop driver more useful.

eighteyes commented 8 years ago

I don't mind normalizing the scale from Matrix side. I'd rather have more control. I suspect certain colors make more lumens then others, and white throws it completely.

On Fri, Aug 12, 2016 at 4:30 AM, Nelson Castillo notifications@github.com wrote:

Hi Andrés and Kevin.

Could you normalize the scale of the LEDs somehow? This will make the everloop driver more useful.

— You are receiving this because you are subscribed to this thread. Reply to this email directly, view it on GitHub https://github.com/matrix-io/matrix-creator-hal/issues/1, or mute the thread https://github.com/notifications/unsubscribe-auth/AAYvGgN_Q1JBPbfIKwR5QDV-1PUt_PDNks5qfFlggaJpZM4JjAF2 .

arhuaco commented 8 years ago

Hi @eighteyes . In any case normalizing outside Matrix side is still good in case somebody uses the LEDs via MALOS or HAL.

eighteyes commented 8 years ago

I'd really like to keep the 0-255 range because then it maps to web colors nicely. That is all.

On Aug 13, 2016 9:58 AM, "Nelson Castillo" notifications@github.com wrote:

Hi @eighteyes https://github.com/eighteyes . In any case normalizing outside Matrix side is still good in case somebody uses the LEDs via MALOS or HAL.

— You are receiving this because you were mentioned. Reply to this email directly, view it on GitHub https://github.com/matrix-io/matrix-creator-hal/issues/1#issuecomment-239630844, or mute the thread https://github.com/notifications/unsubscribe-auth/AAYvGshgeT-8FQ6ZGqSBZDXkAywIMczaks5qffesgaJpZM4JjAF2 .

brianofrokk3r commented 8 years ago

+1 for @eighteyes commit, like that it maps over to web colors nicely.

arhuaco commented 8 years ago

It's not that the colours shouldn't range between 0 and 255. The fact is that once they reach a small number (say 15) the intensity is too high and it is not useful to go beyond that.

arhuaco commented 8 years ago

IMHO this should be fixed in HAL or in a lower layer. I've discussed this with @eljuguetero a bit.

brianofrokk3r commented 8 years ago

@arhuaco the intensity normalized makes sense. I agree with you.

Flowr-es commented 8 years ago

I'm also palying with this and saw that the current maximum seems to be 50 (no documentation, so only assumed from the nodejs demo).

Offtopic: Is there a clean way to convert RGB to RGBW? Internet search delivered only this approach: R=R G=G B=B W=min(R, G, B)

arhuaco commented 8 years ago

Writing documentation for MALOS now. We should normalize the scale @eljuguetero... I wonder if the scale is linear. If we don't fix this here then we should limit the values that can be sent to MALOS because it feels weird to say that the range is [0,255] but that it doesn't make sense after 50.