search

matrix-io / matrix-creator-malos

MATRIX Creator abstraction for MOS
GNU General Public License v3.0
19 stars 18 forks source link

Python Changes and Updates #75

Closed erinxocon closed 7 years ago

erinxocon commented 7 years ago

I have really wanted to use python with my matrix creator and the provided examples were only partially working, I'm assuming due to API changes and what not. I've updated most of the examples and split up test_sensors.py to be more like their JS counterparts. I also wrote a utils.py module that allows some easy setup for an event driven methodology. If you like what I've done and want to include it don't merge it yet! I'm still porting a couple of the examples and I want to add more comments. I've also provided a requirements.txt and a Pipfile for so users can easily add the needed dependencies. I'd also like to change the README.md to relflect the changes I've made in the example files.

Let me know what you think!

hpsaturn commented 7 years ago

nice work! many thanks for your commits! we'll wait then!

erinxocon commented 7 years ago

@hpsaturn I've updated all the files I created/modify to try and comment line by line what is happening, feel free to correct anything! I didn't touch the README.rst as some of it differs after I rearranged some stuff to make it more pythonic. I'll let you decide how you want to handle that. If you want we can work in conjunction to create a new README.

All and all I think it's ready to merge!

Cheers!

erinxocon commented 7 years ago

@hpsaturn Good to hear! I'd be happy to amend my commits with anything new that would be needed with the new protobuffers!

erinxocon commented 7 years ago

@hpsaturn I've merged in the new proto driver changes courtesy of @maciekrb! Anything else to do?

hpsaturn commented 7 years ago

@erinxocon Good news, I add new reviewers and I think so we all ready.