matrix-org / buildkite-webhook-listener

Apache License 2.0
3 stars 1 forks source link

Ensure parameters passed to thread #3

Closed michaelkaye closed 4 years ago

michaelkaye commented 4 years ago

I am also surprised it's required; but my debugging has been such that it logged that it was going to delete them when it started, but when the thread itself actually ran, the test to see if it needed to delete didn't pass, and it didn't perform any actions. I know it didn't perform actions because we were missing the import glob; and we didn't see any exceptions about that.

unless there's a problem with this i'm somewhat minded to merge as it's known-working in production, and get on with other things.