search

matrix-org / complement

Matrix compliance test suite
Apache License 2.0
61 stars 52 forks source link

`TestMediaFilenames` incorrectly tests Content-Disposition #645

Closed Half-Shot closed 1 year ago

Half-Shot commented 1 year ago

Content-Disposition is not a spec defined behaviour (it's not mentioned in https://spec.matrix.org/v1.7/client-server-api/ other than for the filename, and complement should not be prescribing that servers act a certain way without a spec to cover it.

It's up to homeservers to decide what media types may be presented inline or as attachments (and something we're trying to fix in https://github.com/matrix-org/synapse/pull/15988 to fix a unsatisfactory situation).

Half-Shot commented 1 year ago

This appears to have originally come from sytest, which also is testing this behaviour wrongly. https://github.com/matrix-org/complement/pull/639.

Ultimately I'd be in favour of at most checking Content-Disposition is a valid value, but realistically we can't expect developers to pass these tests until the spec defines the requirements.