search

matrix-org / complement

Matrix compliance test suite
Apache License 2.0
61 stars 52 forks source link

Require go 1.19 for atomic.Int64 #687

Closed DMRobertson closed 1 year ago

DMRobertson commented 1 year ago

Synapse tried to build complement using the go version specificed in go.mod, and failed:

 📦 github.com/matrix-org/complement/internal/docker
Error: internal/docker/deployment.go:29:26: undefined: atomic.Int64

See https://github.com/matrix-org/synapse/pull/16567#issuecomment-1784220124 onwards.

clokep commented 1 year ago

Does the setup-go in this repo need to be updated to enforce this? I.e. these have the same warning:

Warning: go-version input was not specified. The action will try to use pre-installed version.

DMRobertson commented 1 year ago

Oh, ISWYM! It feels like it probably ought to.