Implement archived rooms

matrix-org / dendrite

Dendrite is a second-generation Matrix homeserver written in Go!

https://matrix-org.github.io/dendrite/

Apache License 2.0

5.75k stars 676 forks source link

Implement archived rooms #1323

Open kegsay opened 4 years ago

kegsay commented 4 years ago

Specifically this is the include_leave part of the filter. Sytests:

    × Archived rooms only contain history from before the user left

alexchan150 commented 4 years ago

I would like to get started on this!

alexchan150 commented 4 years ago

I'm struggling a bit after going through the sync logic and specs - can't seem to find any references to the roomFilter in the codebase. Is there any more information on the include_leave part and how that pertains to this issue?

kegsay commented 4 years ago

When you leave a room, you no longer get updates to the room, or in fact told about the room at all, via /sync unless you give /sync a filter with include_leave: true. Doing this will cause /sync to return information on left rooms (archived rooms)

MadLittleMods commented 3 years ago

I've removed good first issue as this problem has turned out pretty hard, https://github.com/matrix-org/dendrite/pull/1671

Sytest is hard to work with, figure out what is wrong, and then reason about is that even correct or just Synapse behavior
The CompleteSync/IncrementalSync code is hard to reason about
Needs type filtering for events -> https://github.com/matrix-org/dendrite/pull/1721
Might require better/full history visibility implementation