search

matrix-org / dendrite

Dendrite is a second-generation Matrix homeserver written in Go!
https://matrix-org.github.io/dendrite/
Apache License 2.0
5.67k stars 664 forks source link

"Forgotten room messages cannot be paginated" flakey for Dendrite #1629

Closed S7evinK closed 3 years ago

S7evinK commented 3 years ago

Describe the bug https://buildkite.com/matrix-dot-org/dendrite/builds/3776 https://buildkite.com/matrix-dot-org/dendrite/builds/3774 Two different CI runs for Dendrite.

As far as i can see, in that test, there's a room created as $creator, message sent as $creator but messages are retrieved for $user. I'm not sure if $creator == $user in that case, or at least should be, as the test passes from time to time. (As I'm not so familiar with Perl, would

+ matrix_get_room_messages( $creator, $room_id, limit => 1 );
- matrix_get_room_messages( $user, $room_id, limit => 1 );

be sufficient?)

Expected behavior Test always passes

anoadragon453 commented 3 years ago

Not quite, this test is checking that after $user has left the room and forgotten it, they can no longer paginate messages in that room. $user is definitely the one we want to be checking here, and $creator hasn't left the room and will certainly be able to paginate messages just fine.

This may be either due to Dendrite being flaky, or Sytest not waiting a sufficient amount of time between checks. In any case, I'm going to move this issue to the Dendrite repo instead, as they're probably the best ones to investigate it.

kegsay commented 3 years ago

I have been tracking flakey tests recently. I haven't seen this as an issue. Closing for now.