matrix-org / dendrite

Dendrite is a second-generation Matrix homeserver written in Go!
https://matrix-org.github.io/dendrite/
Apache License 2.0
5.67k stars 664 forks source link

Documentation unclear about requirements / build.sh no good perceptible warnings #2230

Open raypatterson77 opened 2 years ago

raypatterson77 commented 2 years ago

Link to problem area: https://github.com/matrix-org/dendrite/blob/main/docs/INSTALL.md

Issue

Documentation is unclear about requirements

gcc --version
gcc (Debian 10.2.1-6) 10.2.1 20210110
[...]

Expected behavior

If this is not wanted for a particular reason I can create a pull request and add git and gcc to the requirements but I'm not sure about the miniumum versions

catsmeows commented 2 years ago

Seen this with old go version which simply hangs for build.sh. So thumbs up for bringing this up

ealib commented 2 years ago

It would probably be appropriate to break the INSTALL.md document into

So as to separate concerns: if and only if I have built successfully, then I install.