search

matrix-org / dendrite

Dendrite is a second-generation Matrix homeserver written in Go!
https://matrix-org.github.io/dendrite/
Apache License 2.0
5.75k stars 676 forks source link

Rate limiting affects server administrator #2590

Open boogewooge opened 2 years ago

boogewooge commented 2 years ago

Background information

In https://github.com/matrix-org/dendrite/issues/2589, where rate_limiting being enabled causes issues, a server administrator (more than one in fact) was also affected, though https://github.com/matrix-org/dendrite/blob/main/dendrite-sample.monolith.yaml#L182= indicates that shouldn't be the case.

kegsay commented 2 years ago

We need to ensure we're testing that exempt_user_ids are actually being exempted from the rate limiting code.

S7evinK commented 2 years ago

The problem I'm seeing is that the endpoint doesn't require authentication, so we don't have a device we can check for admin/exempt users.