Scrollback shows mxids and blank avatars after a certain point

matrix-org / dendrite

Dendrite is a second-generation Matrix homeserver written in Go!

https://matrix-org.github.io/dendrite/

Apache License 2.0

5.75k stars 676 forks source link

Scrollback shows mxids and blank avatars after a certain point #2734

Open 0x1a8510f2 opened 2 years ago

0x1a8510f2 commented 2 years ago

Background information

Dendrite version or git SHA: d5978d98fda8a31918973a2481e62eafcec9f80f (but bug noted in every version so far)
Monolith or Polylith?: Monolith
SQLite3 or Postgres?: Postgres
Running in Docker?: Yes
go version: n/a
Client used (if applicable): Element Web / Element Android

Description

What is the problem: When scrolling back in the timeline, messages after a certain point do not show the sender's displayname or avatar, only their mxid.
Who is affected: Users of the homeserver.
How is this bug manifesting: Missing user avatars and displaynames in scrollback.
When did this first appear: Since I've been using Dendrite.

Steps to reproduce

Open any room
Scroll up

bones-was-here commented 2 years ago

Sometimes this can happen without needing to scroll up, I will see a user's newer messages with display name and avatar, and their older messages without.

S7evinK commented 2 years ago

I can confirm this with Element Web, but not Element Android. At first glance it looks like it's related to lazy loading members. Might be that Element Web evicts the already lazy loaded members after several calls to /messages or when the already loaded events are out of range (to save memory).

S7evinK commented 2 years ago

Looks like https://github.com/vector-im/element-web/issues/7417

0x1a8510f2 commented 2 years ago

I'm fairly sure I've seen this happen with EA too. Let me see if I can get a screenshot.

bones-was-here commented 2 years ago

In a recent version (0.10.6 or 0.10.5) this has improved for me: i no longer see mxids with no avatars every time I clear cache & reload in Element Web. Would be nice if Element didn't require everyone to click that button all the time though...

0x1a8510f2 commented 2 years ago

It looks like it happens interminnently in scroll back on EA.

z411 commented 1 year ago

It seems the exact combination to reproduce is a Dendrite server and a react sdk based client (ie Element, Cinny).