Implement `/_matrix/client/v1/rooms/{roomId}/threads` (I am being lazy so can someone finish off this for me?)

matrix-org / dendrite

Dendrite is a second-generation Matrix homeserver written in Go!

https://matrix-org.github.io/dendrite/

Apache License 2.0

5.74k stars 676 forks source link

Implement `/_matrix/client/v1/rooms/{roomId}/threads` (I am being lazy so can someone finish off this for me?) #3404

Open qwqtoday opened 3 months ago

qwqtoday commented 3 months ago

Signed-off-by: Leung Ho Ching <lukas.leung@hotmail.com>

Pull Request Checklist

[x] I have added Go unit tests or Complement integration tests for this PR or I have justified why this PR doesn't need tests
[x] Pull request includes a sign off below using a legally identifiable name or I have already signed off privately

qwqtoday commented 3 months ago

this pr doesn't need tests because it's obviously working

notramo commented 3 months ago

It needs tests so when new features are added or refactored, it won't break, and other devs who submit different pull requests, don't have to test this feature each time they submit a new PR. Tests are for future stability, the current feature is obviously always working, because if it wouldn't work, the dev would spend more time on it. But when 10 other features are added, nobody wants to manually test this feature 10 times to avoid breaking it while implementing those new features.

qwqtoday commented 3 months ago

It needs tests so when new features are added or refactored, it won't break, and other devs who submit different pull requests, don't have to test this feature each time they submit a new PR. Tests are for future stability, the current feature is obviously always working, because if it wouldn't work, the dev would spend more time on it. But when 10 other features are added, nobody wants to manually test this feature 10 times to avoid breaking it while implementing those new features.

Sure I will do it later

qwqtoday commented 3 months ago

@S7evinK can you run the workflow to test it?

S7evinK commented 1 week ago

Thanks for contributing to Dendrite!

The repo has been cloned into element-hq/dendrite and made the switch to AGPL as per https://matrix.org/blog/2023/11/06/future-of-synapse-dendrite/. For more information, feel free to read this and this

If you still wish to contribute under the new license, feel free to create a new PR over at element-hq/dendrite.