search

matrix-org / dendron

Dendron was an experimental Matrix homeserver, succeeded by Dendrite.
35 stars 9 forks source link

A "context.Context" should be used to shutdown more cleanly #46

Closed euank closed 4 years ago

euank commented 7 years ago

Currently, there's the terminate channel used to signal the server should shutdown.

Due to the defer cleanups for the processes spawned, those are nicely cleaned up on terminate, but the version handler is not given such an opportunity. Presumably, this will also apply to other handlers and components in the future.

I think we should have good hygiene about using a context.Context from the beginning, and in addition should replace the defer cleanup with a ctx as well.

I'm happy to make this change if it makes sense to have.

euank commented 4 years ago

This project was abandoned, closing issue.