search

matrix-org / emojibase-bindings

Packages emojibase bindings for iOS and Android
Apache License 2.0
3 stars 1 forks source link

Typescript to create the json and swift bindings #1

Closed langleyd closed 1 year ago

langleyd commented 1 year ago
langleyd commented 1 year ago

@t3chguy any chance you would be able to add the renovate and release/test automation when adding the npm publishing? I see you did a very nice job of matrix-analytics-events :).

On the swift side we've get publishing/versioning for free as long as the github releases are created.

I can tag this manually after this PR and that will allow me integrate the on element-x-ios. I'll get to work on the kotlin bindings then.

t3chguy commented 1 year ago

On the swift side we've get publishing/versioning for free as long as the github releases are created.

Is it about the github release or just the git tag?

@t3chguy any chance you would be able to add the renovate and release/test automation when adding the npm publishing? I see you did a very nice job of matrix-analytics-events :).

Sure

langleyd commented 1 year ago

Is it about the github release or just the git tag?

Sorry yea just the tag.

langleyd commented 1 year ago

Think we should have a github workflow linter to prevent the emojibase.json from falling out of sync

Do you mean using renovate to stop it getting out of sync with the upstream emojibase?

Or something that validates the json against a schema?

Or something else?

t3chguy commented 1 year ago

@langleyd I mean something that asserts the iOS JSON file matches what you'd get if you ran yarn start - if you have build artifacts in your sources you need to protect against them falling stale.

yarn start
git diff --exit-code
langleyd commented 1 year ago

Added, thanks for that.