Upgrade Emojibase and Add emoticon variations

matrix-org / emojibase-bindings

Packages emojibase bindings for iOS and Android

Apache License 2.0

3 stars 1 forks source link

Closed langleyd closed 1 month ago

langleyd commented 1 month ago

Updates emojibase to 15.3.1 so that we can use their utility generateEmoticonPermutations to generate variations of plain text emoticons(e.g. with or without nose :) :-)).
Adds an explicit MAX_EMOJI_VERSION_WEB to filter out newer emojis from inclusion as web is not ready to upgrade yet (it needs to be upgraded in unison with twemoji (which is awkward and beyond the scope of this PR)
It also adds MAX_EMOJI_VERSION_ANDROID and MAX_EMOJI_VERSION_IOS to the script that generates the emojibase.json for those platforms so that they can move forward.

pixlwave commented 1 month ago

Dropping in uninvited to ask an important question!

Adds an explicit MAX_EMOJI_VERSION to filter out newer emojis from inclusion as web is not ready to upgrade yet

Does this work per platform? Apple supports 15.1 and I'd love to get the 🙂‍↕️ and 🙂‍↔️ reactions on iOS if we could 😇

langleyd commented 1 month ago

@pixlwave yea we could probably load it via an env variable. Will take a look.

pixlwave commented 1 month ago

Amazing, thank you! 🙌

langleyd commented 1 month ago

@bmarty We've split out the max emoji version per platform as per the PR description.

Would you(Android) like add emoji 15.1 support similar to iOS? (Web needs to stay on 15.0 for now).

langleyd commented 1 month ago

Confirmed with Android team they want to move to 15.1.