matrix-org / gomatrix

A Golang Matrix client
Apache License 2.0
285 stars 53 forks source link

Add ThumbnailInfo to ImageInfo #63

Closed btittelbach closed 5 years ago

babolivier commented 5 years ago

Hey @btittelbach, and thanks for your PR! I think there's a misunderstanding here, though: the ImageInfo structure is supposed to represent the ImageInfo structure from this section rather than the content of the m.image msgtype. The said content is missing from gomatrix, however, which I suppose is because we never had the need to implement it. If it's the m.image msgtype content you need, please open a new PR implementing this. I'm closing this one for now.

btittelbach commented 5 years ago

I see, thanks for the hint. Guess I got confused since VideoInfo works differently than ImageInfo in the specs and many client seem to send VideoInfo like ImageInfos when I looked for examples in my matrix stream.