matrix-org / gomatrix

A Golang Matrix client

Apache License 2.0

285 stars 53 forks source link

Switch to golangci-lint #75

Closed ptman closed 4 years ago

ptman commented 4 years ago

Which go version should be targeted? Is 1.12 even supported anymore?

ptman commented 4 years ago

59

ptman commented 4 years ago

What should be done about lint errors? //nolint? fix them?

neilalexander commented 4 years ago

It's best to fix the lint errors if you don't mind.

ptman commented 4 years ago

Better?

ptman commented 4 years ago

@neilalexander PTAL

ptman commented 4 years ago

@neilalexander PTAL

ptman commented 4 years ago

or @Kegsay / @t3chguy

neilalexander commented 4 years ago

Generally looks fine - we do require Go 1.13 now though and I think our gocyclo limit is 13. Happy to merge once those tweaks are made if @Kegsay is also happy?

kegsay commented 4 years ago

LGTM

marco-m commented 4 years ago

ping ?

ptman commented 4 years ago

oh, new conflicts, I'll have a look tomorrow, but please merge it then before new conflicts appear

ptman commented 4 years ago

Oh, @neilalexander already did this in #78 ?

neilalexander commented 4 years ago

Ah, yes, I forgot about this PR and was prompted to do it the other day after speaking to someone.

neilalexander commented 4 years ago

Closing since already done - thanks for looking into this though / for the reminder.