S7evinK
commented
1 year ago Also, from manually testing: Rejecting invites doesn't seem to do the right thing, possibly only in the SyncAPI, as instead of @bob:server2.localhost rejected the invitation I'm seeing @bob:server2.localhost left the room instead.
Codecov Report
Patch coverage:
60.96% and project coverage change:+0.58:tada:Additional details and impacted files
```diff @@ Coverage Diff @@ ## main #398 +/- ## ========================================== + Coverage 56.95% 57.54% +0.58% ========================================== Files 50 51 +1 Lines 6632 6962 +330 ========================================== + Hits 3777 4006 +229 - Misses 2498 2561 +63 - Partials 357 395 +38 ``` | [Impacted Files](https://app.codecov.io/gh/matrix-org/gomatrixserverlib/pull/398?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=matrix-org) | Coverage Δ | | |---|---|---| | [eventcontent.go](https://app.codecov.io/gh/matrix-org/gomatrixserverlib/pull/398?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=matrix-org#diff-ZXZlbnRjb250ZW50Lmdv) | `76.43% <ø> (ø)` | | | [fclient/federationclient.go](https://app.codecov.io/gh/matrix-org/gomatrixserverlib/pull/398?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=matrix-org#diff-ZmNsaWVudC9mZWRlcmF0aW9uY2xpZW50Lmdv) | `11.55% <0.00%> (-0.32%)` | :arrow_down: | | [eventauth.go](https://app.codecov.io/gh/matrix-org/gomatrixserverlib/pull/398?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=matrix-org#diff-ZXZlbnRhdXRoLmdv) | `56.97% <25.00%> (+1.99%)` | :arrow_up: | | [keyring.go](https://app.codecov.io/gh/matrix-org/gomatrixserverlib/pull/398?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=matrix-org#diff-a2V5cmluZy5nbw==) | `40.37% <37.93%> (-0.21%)` | :arrow_down: | | [spec/senderid.go](https://app.codecov.io/gh/matrix-org/gomatrixserverlib/pull/398?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=matrix-org#diff-c3BlYy9zZW5kZXJpZC5nbw==) | `62.50% <50.00%> (-37.50%)` | :arrow_down: | | [performjoin.go](https://app.codecov.io/gh/matrix-org/gomatrixserverlib/pull/398?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=matrix-org#diff-cGVyZm9ybWpvaW4uZ28=) | `59.79% <52.05%> (-1.49%)` | :arrow_down: | | [invite.go](https://app.codecov.io/gh/matrix-org/gomatrixserverlib/pull/398?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=matrix-org#diff-aW52aXRlLmdv) | `79.27% <53.33%> (-5.34%)` | :arrow_down: | | [handlejoin.go](https://app.codecov.io/gh/matrix-org/gomatrixserverlib/pull/398?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=matrix-org#diff-aGFuZGxlam9pbi5nbw==) | `73.06% <57.14%> (-2.64%)` | :arrow_down: | | [fclient/invitev3.go](https://app.codecov.io/gh/matrix-org/gomatrixserverlib/pull/398?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=matrix-org#diff-ZmNsaWVudC9pbnZpdGV2My5nbw==) | `66.66% <66.66%> (ø)` | | | [performinvite.go](https://app.codecov.io/gh/matrix-org/gomatrixserverlib/pull/398?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=matrix-org#diff-cGVyZm9ybWludml0ZS5nbw==) | `68.33% <68.58%> (-25.67%)` | :arrow_down: | | ... and [2 more](https://app.codecov.io/gh/matrix-org/gomatrixserverlib/pull/398?src=pr&el=tree-more&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=matrix-org) | | ... and [4 files with indirect coverage changes](https://app.codecov.io/gh/matrix-org/gomatrixserverlib/pull/398/indirect-changes?src=pr&el=tree-more&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=matrix-org):umbrella: View full report in Codecov by Sentry.
:loudspeaker: Do you have feedback about the report comment? Let us know in this issue.