matrix-org / gomatrixserverlib

Go library for matrix federation.
Apache License 2.0
62 stars 51 forks source link

Disable character range check for user IDs #410

Open neilalexander opened 1 year ago

neilalexander commented 1 year ago

This check is not safe in existing room versions because Synapse hasn't enforced it properly either.

Related: matrix-org/matrix-spec#1506, matrix-org/matrix-spec-proposals#2828

Signed-off-by: Neil Alexander git@neilalexander.dev

codecov[bot] commented 1 year ago

Codecov Report

Patch coverage: 100.00% and project coverage change: +0.09% :tada:

Comparison is base (c48e302) 58.37% compared to head (ac984c7) 58.47%.

Additional details and impacted files ```diff @@ Coverage Diff @@ ## main #410 +/- ## ========================================== + Coverage 58.37% 58.47% +0.09% ========================================== Files 51 51 Lines 7023 7032 +9 ========================================== + Hits 4100 4112 +12 + Misses 2533 2531 -2 + Partials 390 389 -1 ``` | [Files Changed](https://app.codecov.io/gh/matrix-org/gomatrixserverlib/pull/410?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=matrix-org) | Coverage Δ | | |---|---|---| | [spec/userid.go](https://app.codecov.io/gh/matrix-org/gomatrixserverlib/pull/410?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=matrix-org#diff-c3BlYy91c2VyaWQuZ28=) | `94.64% <100.00%> (+7.40%)` | :arrow_up: |

:umbrella: View full report in Codecov by Sentry.
:loudspeaker: Have feedback on the report? Share it here.

neilalexander commented 1 year ago

cc @S7evinK @devonh