search

matrix-org / gomatrixserverlib

Go library for matrix federation.
Apache License 2.0
62 stars 51 forks source link

Extend fed client interface for complement usage #415

Closed devonh closed 1 year ago

codecov[bot] commented 1 year ago

Codecov Report

Patch and project coverage have no change.

Comparison is base (095d10f) 58.68% compared to head (50a984a) 58.68%.

Additional details and impacted files ```diff @@ Coverage Diff @@ ## main #415 +/- ## ======================================= Coverage 58.68% 58.68% ======================================= Files 51 51 Lines 7062 7062 ======================================= Hits 4144 4144 Misses 2529 2529 Partials 389 389 ``` | [Files Changed](https://app.codecov.io/gh/matrix-org/gomatrixserverlib/pull/415?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=matrix-org) | Coverage Δ | | |---|---|---| | [fclient/federationclient.go](https://app.codecov.io/gh/matrix-org/gomatrixserverlib/pull/415?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=matrix-org#diff-ZmNsaWVudC9mZWRlcmF0aW9uY2xpZW50Lmdv) | `11.55% <ø> (ø)` | |

:umbrella: View full report in Codecov by Sentry.
:loudspeaker: Have feedback on the report? Share it here.

devonh commented 1 year ago

LGTM, but surely we need a concrete impl of these functions somewhere in GMSL too?

They already exist, we just weren't exposing them in the interface since Dendrite must not use them.