search

matrix-org / gomatrixserverlib

Go library for matrix federation.
Apache License 2.0
62 stars 51 forks source link

Default PowerLevelContent.Invite to 0 per matrix spec #416

Closed NickCao closed 1 year ago

NickCao commented 1 year ago

The default power level for invite was wrong in matrix spec v1.1[1], and has been fixed in v1.3, bringing us in line with synase[2].

[1] https://github.com/matrix-org/matrix-spec/commit/136b5c9231dde8f5b95f495e60b5d2315608a886 [2] https://github.com/matrix-org/synapse/blob/v1.92.3/synapse/handlers/event_auth.py#L138

Pull Request Checklist

Signed-off-by: Nick Cao <nickcao@nichi.co>

S7evinK commented 1 year ago

Can you take a look at the failing tests please?

NickCao commented 1 year ago

Can you take a look at the failing tests please?

Solved.

codecov[bot] commented 1 year ago

Codecov Report

All modified lines are covered by tests :white_check_mark:

Comparison is base (79fcff2) 58.76% compared to head (519cf56) 58.73%.

:exclamation: Current head 519cf56 differs from pull request most recent head aabc552. Consider uploading reports for the commit aabc552 to get more accurate results

Additional details and impacted files ```diff @@ Coverage Diff @@ ## main #416 +/- ## ========================================== - Coverage 58.76% 58.73% -0.03% ========================================== Files 51 51 Lines 7098 7098 ========================================== - Hits 4171 4169 -2 - Misses 2536 2538 +2 Partials 391 391 ``` | [Files](https://app.codecov.io/gh/matrix-org/gomatrixserverlib/pull/416?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=matrix-org) | Coverage Δ | | |---|---|---| | [eventcontent.go](https://app.codecov.io/gh/matrix-org/gomatrixserverlib/pull/416?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=matrix-org#diff-ZXZlbnRjb250ZW50Lmdv) | `75.16% <100.00%> (ø)` | | ... and [1 file with indirect coverage changes](https://app.codecov.io/gh/matrix-org/gomatrixserverlib/pull/416/indirect-changes?src=pr&el=tree-more&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=matrix-org)

:umbrella: View full report in Codecov by Sentry.
:loudspeaker: Have feedback on the report? Share it here.