search

matrix-org / matrix-analytics-events

Cross-platform definitions of analytics events raised by matrix SDKs
Apache License 2.0
8 stars 7 forks source link

Remove `platformCodeName` super property, and use existing `appPlatform` instead #106

Closed BillCarsonFr closed 3 months ago

BillCarsonFr commented 3 months ago

Depends on https://github.com/matrix-org/matrix-analytics-events/pull/105 as the existing Values for appPlatform have white spaces

RemoveplatformCodeName and reuse appPlatform has now we can have enum values with whitespace. Reverts https://github.com/matrix-org/matrix-analytics-events/pull/104 and adding the new needed enum values as per https://github.com/element-hq/crypto-internal/issues/316

First commit has the schema changes. The other one is just running the script to generate the updated swift/kotlin files

richvdh commented 3 months ago

I think this reverts https://github.com/matrix-org/matrix-analytics-events/pull/104?

BillCarsonFr commented 3 months ago

LGTM

yes updated PR description