Sanitise UserProperties schema

matrix-org / matrix-analytics-events

Cross-platform definitions of analytics events raised by matrix SDKs

Apache License 2.0

8 stars 8 forks source link

Closed t3chguy closed 2 years ago

t3chguy commented 2 years ago

It isn't an event so shouldn't have an eventName

We may wish to further split it into SetUserProperties and SetOnceUserProperties to provide full context

pixlwave commented 2 years ago

Looks good to me 👍

I made a small PR to your PR to remove the protocol conformance for Swift as this would fail to compile without the event name being present: https://github.com/matrix-org/matrix-analytics-events/pull/29

t3chguy commented 2 years ago

@pixlwave in future feel free to push commits onto my branches :)

pixlwave commented 2 years ago

Ok thanks, I didn't want to make any assumptions 🙂