Ensure generated Kotlin code follow Kotlin naming convention

matrix-org / matrix-analytics-events

Cross-platform definitions of analytics events raised by matrix SDKs

Apache License 2.0

8 stars 7 forks source link

Ensure generated Kotlin code follow Kotlin naming convention #62

Closed bmarty closed 2 years ago

bmarty commented 2 years ago

Constructor parameters cannot start by an upper case letter. This PR fixes that, hopefully without any side effect on the sent analytics, and on the other generated code.

ouchadam commented 2 years ago

codewise the fix LGTM, there's still a pending question of if this change is needed and sets a precedent for allowing future inconsistent property naming

perhaps we can merge this and create a separate issue to provide a github action to linter to enforce consistency in the json schemas