search

matrix-org / matrix-analytics-events

Cross-platform definitions of analytics events raised by matrix SDKs
Apache License 2.0
8 stars 8 forks source link

Add some missing periods. #63

Closed bmarty closed 2 years ago

bmarty commented 2 years ago

The generated code is analyzed by Detekt when imported in the Element Android project, and the Kdoc content is (or rather will be) checked. Sentences have to end with a period.

t3chguy commented 2 years ago

If this is something we should adhere to then please write it into the contributing guide for this repo

bmarty commented 2 years ago

If this is something we should adhere to then please write it into the contributing guide for this repo

Good point: c438b8c

pixlwave commented 2 years ago

One question, how come only the Kotlin files are updated?

bmarty commented 2 years ago

One question, how come only the Kotlin files are updated?

My bad, I am calling yarn build:kt2 to be faster.

c1e0c1aca4eeeb2160c371c1547b1a014529926c contains all the generated files.

pixlwave commented 2 years ago

LGTM 👌