search

matrix-org / matrix-android-console

Apache License 2.0
26 stars 16 forks source link

Fix #2 by updating SDK version, build tools, etc #17

Closed mitchhentges closed 6 years ago

pvagner commented 8 years ago

It builds fine for me after applying it.

ara4n commented 8 years ago

i've added various questions, plus I suspect we'll be quite paranoid about upgrading to 23 and will test it a bunch before merging.

ylecollen commented 8 years ago

1 - i tested gradle-2.11 this week-end and it crashed a few times whereas it does not crash with oldest gradle versions.

2 - the build tools and the sdk version should be the same i.e. SDK 23 and builtools 23 (+ compat). It is not common to use an old SDK with a recent buildtools (because of compat issues).

mitchhentges commented 8 years ago

1: Remaining with an old version of software isn't a good idea, because eventually it will be unsupported. If we keep up with the current version, not only will we gain a bunch of performance improvements and bug fixes, but we'll be more agile on future changes.

I'm surprised that you've had issues with gradle 2.11 crashing. Google has developers use gradle directly, and they're using gradle 2.10/2.11 in their next build of Android Studio (the one with continuous deployment). If Google is recommending it, it should be a safe bet.

2: I've updated the builds tools and SDK version! I had to change notifications a little bit, but it still works (at least on an Android M device). I've changed the target to SDK 23, because the only real change is that permissions are requested on-the-fly, and I think that we already deal with that