search

matrix-org / matrix-android-sdk

The Matrix SDK for Android - DEPRECATED
Apache License 2.0
370 stars 132 forks source link

Flavour without jitsi #353

Open Bubu opened 6 years ago

Bubu commented 6 years ago

Would you accept a build flavour of this sdk that removes the jitsi dependency? I'm currently maintaining a fork for the f-droid build of miniVector here: https://github.com/Bubu/matrix-android-sdk/tree/no_webrtc

It's only a tiny amount of changes that's necessary and hopefully easy to wrap in a flavour. I hope this would significantly reduce the maintenance load for keeping miniVector updated for f-droid.

bmarty commented 5 years ago

Yes. FYI, some work has been done for another Matrix client here: https://github.com/dinsic-pim/tchap-android/commit/f366b48723362202a0db707405b1758265979728

Bubu commented 5 years ago

Interesting. But this is riot code, right? This has been done in https://github.com/LiMium/mini-vector-android as well. This issue was about making it optional here at sdk level. This 1) will save some more space in the final apk and 2) will make building from source (including dependencies) much easier :-).

bmarty commented 5 years ago

Yes, it's a fork from Riot. I understood the issue ;-) 2 build flavours will generate 2 aar lib. I'm ok to accept a PR with this and then I will update our Jenkins job for him to build both flavors

Bubu commented 5 years ago

Cool! Will look into it after vacation :)

hrj commented 5 years ago

@Bubu I think this is what is now causing miniVector to bloat up in v0.9.1. The flavour without jitsi would be mighty useful.

hrj commented 5 years ago

@bmarty Would you consider a more drastic suggestion: move the jitsi dependency out of matrix-android-sdk completely? The webrtc part is anyway not part of the matrix protocol. And there are just two classes in the sdk that handle the session management. Perhaps they could be rolled into a separate library, or moved to the client project itself.