Improve the push rules handling - Githubissues

matrix-org / matrix-android-sdk

The Matrix SDK for Android - DEPRECATED

Apache License 2.0

370 stars 132 forks source link

Improve the push rules handling #563

Closed giomfo closed 4 years ago

giomfo commented 4 years ago

Consider only the push rules data retrieved thanks to the server sync response
Initialize the BingRulesManager with the stored push rules, instead of request them to the server
Do not use anymore the C-S request to get the push rules directly (This is useless)
Remove "onBingRulesUpdateListener" from BingRulesManager, it was not used

API Change:

MXDataHandler: refreshPushRules() has been removed - we trust the server sync response
BingRulesManager: loadRules() has been removed - we trust the server sync response
BingRulesManager: an update of the push rules is not forced anymore when a rule is deleted, added or updated. We let the server sync handle this push rules update.
BingRulesManager: the interface onBingRulesUpdateListener has been removed. Use MXEventListener instead.

giomfo commented 4 years ago

But why you do not want to merge it on /develop?

I just wasn't sure API breaks were welcome on /develop