search

matrix-org / matrix-appservice-discord

A bridge between Matrix and Discord.
Apache License 2.0
810 stars 151 forks source link

Better parsing for various embed fields. #284

Closed TildeSlashC0re closed 5 years ago

TildeSlashC0re commented 6 years ago

As is, parsing embeds currently leaves out some fields that are provided by the discord spec, which can lead to dissatisfying results on the matrix-side of things.

I can provide screenshots if necessary.

Sorunome commented 6 years ago

I can provide screenshots if necessary.

would be cool! And as embeds are commonly triggered by discord bots, would be also cool if you could say which ones so that soru can do better development on it ^^

TildeSlashC0re commented 6 years ago

That'd be one example. The main focus here being the undefined string instead of the desired AK // Our Destination ... this represents the author.name and author.link (reference) fields in this case.

Sorunome commented 5 years ago

@TildeSlashC0re which bot is that you are using? Soru is looking into it and is a bit puzzled on the undefined currently

TildeSlashC0re commented 5 years ago

https://github.com/Cog-Creators/Red-DiscordBot/blob/develop/cogs/audio.py#L1844

:>

Sorunome commented 5 years ago

Should be greatly improved with #404 and #420