matrix-org / matrix-appservice-discord

A bridge between Matrix and Discord.
Apache License 2.0
791 stars 148 forks source link

Track a slightly fresher fork of better-discord.js #858

Closed tadzik closed 1 year ago

tadzik commented 1 year ago

This fixes a crash related to voice channel message handling.

FSG-Cat commented 1 year ago

If I may ask why are we switching to a branch that is a a single commit ahead? Isn't it a better idea to then climb up the tree to discordjs main if we want a more updated version?

Half-Shot commented 1 year ago

Hiya @FSG-Cat, it's a good point:

We're updating to fix a specific bug, and are considering updating to stock in the future. It would take considerable effort to refactor the bridge for the moment, so we want to ensure we fix the more pressing bug, then circle back to refactoring later :)

Thanks for raising it!

Miepee commented 1 year ago

Which bug was it? If it's user facing, maybe mention that in the changelog as well?

FSG-Cat commented 1 year ago

Hiya @FSG-Cat, it's a good point:

We're updating to fix a specific bug, and are considering updating to stock in the future. It would take considerable effort to refactor the bridge for the moment, so we want to ensure we fix the more pressing bug, then circle back to refactoring later :)

Thanks for raising it!

Thanks for the information.

turt2live commented 1 year ago

uh, you should be able to switch to upstream.

erkinalp commented 1 year ago

alternative: switch to fosscord.js which is a fork of discord.js with third party instance support.

tadzik commented 1 year ago

I clarified the issue in both the commit message and the changelog.

The switch to upstream discord/fosscord.js is very much on our radar, but given how far behind we are and all the API changes that happened in the upstream since the version we're on, this is a significantly bigger effort that'll take us a while to complete.

This is a hotfix to fix a voice-channel related crash, just to improve the stability of the bridge while the proper upstream sync is still brewing.