matrix-org / matrix-appservice-discord

A bridge between Matrix and Discord.
Apache License 2.0
785 stars 148 forks source link

Sending image from M to D shows file name on top, potential privacy issue #871

Open juliloving opened 1 year ago

juliloving commented 1 year ago

This could be a potential privacy issue, because it shows when a photo was taken and which app the screenshot was on

Sometimes saving an image from Mastodon on Firefox will show the person's username in the files, which could be sent and shown right above

I know that this happens on Discord as well, but not as a caption right above the message for all to see. Is there a way to at least convert all images to say "image.png" if the caption can't be dropped?

jaller94 commented 1 year ago

I think that this is the relevant code: https://github.com/matrix-org/matrix-appservice-discord/blob/ac5180ed11e67ea9c1e6467941148b90dd122fb5/src/matrixeventprocessor.ts#L364-L368

JulianGro commented 1 year ago

Just for consideration: Discord saves the file name of anything you upload to it. The same applies to Matrix/Element. So even if the file name doesn't appear in the message, it is still available.

juliloving commented 1 year ago

Just for consideration: Discord saves the file name of anything you upload to it. The same applies to Matrix/Element. So even if the file name doesn't appear in the message, it is still available.

I understand that, I just think the option to make it less visible than the others are would be better. Also, they changed the mobile apps in a recent update to not show the file name in the viewer anymore