search

matrix-org / matrix-appservice-discord

A bridge between Matrix and Discord.
Apache License 2.0
785 stars 148 forks source link

Add Discord Announcement channels to allowed bridging types #889

Open TheTechmage opened 11 months ago

TheTechmage commented 11 months ago

Add the News/Announcement channel type to the list of allowed channel types to bridge between. This can be useful for administrators to centralize announcements between services to reduce the ammount of busy-work that they may need to do.

This fixes #774 and it fixes #813, which is a duplicate

Miepee commented 11 months ago

May be useful to add a test.

TheTechmage commented 11 months ago

I'm not sure how to add a test for this kind of stuff, eheh. Most of the code I deal with are core python services that don't exactly rely on external services :sweat_smile:

Always willing to learn, I just don't know where to start for something out of my field of expertise.

Miepee commented 11 months ago

Not that familiar either, but you probably want to make a copy of this test here: https://github.com/matrix-org/matrix-appservice-discord/blob/abf295045007a2504acff96e56a330e7e5ce0a16/test/test_matrixeventprocessor.ts#L255 And then check whether non-announcement and announcement messages in news channel work.

TheTechmage commented 11 months ago

Thank you for pointing me in the right direction! Got a test added

Henry-Hiles commented 3 months ago

Are there any blockers on this PR? Its quite badly needed.