search

matrix-org / matrix-appservice-gitter

Matrix <-> Gitter bridge
Apache License 2.0
41 stars 12 forks source link

Leave unhandled rooms #64

Closed Half-Shot closed 3 years ago

Half-Shot commented 6 years ago

As a potential fix to https://github.com/matrix-org/matrix-appservice-gitter/issues/63

Half-Shot commented 6 years ago

(Gah, review and assign look the same :disappointed: ) Advise on how sane this looks, potentially dangerous in the wild but hopefully will save us some AS cycle time and users who find the bot won't leave the room.

Half-Shot commented 6 years ago

I am quite worried by handled because handled != interested. Really we should have a flag for determining if we are interested and handled is a separate thing about whether we handled the event successfully.

lukebarnard1 commented 6 years ago

I think it could certainly be clearer about what is the set of events that the bridge will do something with.

Taking events and doing nothing with them and returning early to indicate "I'm not doing anything with this, and that's ok" is unclear when used in conjunction with handled.

Arguably, this is not the best way to handle a room that isn't being handled..

Perhaps it would be better to be explicit. If an event is received from a room that the bridge doesn't think it is bridging, that means it's in a room that it shouldn't be. So perhaps the better option is to check the canonical bridged rooms list and leave if an event is received from an unknown room.

SISheogorath commented 5 years ago

I would definitely love to see the gitter bot to leave the channel, when its no longer used for bridging. Currently I have a room where I recently removed all gitter bridges but the bot is still around and has dangerously high privileges.