matrix-org / matrix-appservice-gitter

Matrix <-> Gitter bridge
Apache License 2.0
41 stars 12 forks source link

Posting an image from Matrix -> Gitter does not work #65

Open devnoname120 opened 6 years ago

devnoname120 commented 6 years ago

Room:

How it looks from Riot: image

How it looks from Gitter: image

Source of the image message:

{
  "origin_server_ts": 1530114644742,
  "sender": "@noname120:matrix.org",
  "event_id": "$1530114644346124qTqmJ:matrix.org",
  "unsigned": {
    "age": 99246,
    "transaction_id": "m1530114648133.199"
  },
  "content": {
    "body": "image.png",
    "info": {
      "mimetype": "image/png",
      "thumbnail_info": {
        "mimetype": "image/png",
        "h": 222,
        "w": 799,
        "size": 38848
      },
      "h": 222,
      "thumbnail_url": "mxc://matrix.org/evTRpifohxyOUuQWeaJeZHtH",
      "w": 799,
      "size": 33839
    },
    "msgtype": "m.image",
    "url": "mxc://matrix.org/pAiUxsUmEWUtUMEwTAdRozel"
  },
  "type": "m.room.message",
  "room_id": "!lfkzGdqQhBqHTsDQLV:matrix.org"
}
jezcope commented 4 years ago

Gitter supports posting inline images using Markdown: ![Optional image title](image URL)

Could m.image messages be translated to this on the Gitter side?

jezcope commented 4 years ago

Huh, looks like this is already done: https://github.com/matrix-org/matrix-appservice-gitter/blob/bb1ea44000e4fe10554b993f84b2515d8b812164/lib/BridgedRoom.js#L657

Maybe I just need to update my instance of the bridge.

MarkWieczorek commented 4 years ago

Posting of images in Matrix still don't get relayed to Gitter. Here is what it looks like for me in Gitter:

Screen Shot 2020-04-15 at 12 22 33