matrix-org / matrix-appservice-irc

Node.js IRC bridge for Matrix
Apache License 2.0
460 stars 149 forks source link

Issue joining Freenode IRC rooms w/ special characters in password #1178

Open Rspigler opened 3 years ago

Rspigler commented 3 years ago

I followed the wiki here: https://github.com/matrix-org/matrix-appservice-irc/wiki/Guide:-How-to-use-Matrix-to-participate-in-IRC-rooms

Describe the bug I was able to communicate with @appservice-irc:matrix.org to (test) change my nick, and communicate with NickServ to register, and set my password without error. However, Identify resulted in:

o'@ is not a registered nickname. This nickname is registered. Please choose a different nickname, or identify via /msg NickServ identify .

o'@ was a segment of my password.

When I tried to join restricted rooms, I received an error saying I needed a registered nick.

I changed my password to just alphanumeric, and this was solved.

To Reproduce See above.

Expected behavior Is this an error in Matrix protocol, Element's implementation, or Freenode? Don't know. But perhaps a warning is needed before creating the password in the short term.

Desktop (please complete the following information):

tadzik commented 2 years ago

I cannot reproduce it.

I tried registering a username with nickserv, with foo'@bar in a password, which worked fine. Then !storepass <server> foo'@bar and !reconnect authenticated me successfully. This was tested on ergo ircd.

I tried talking to @freenode_nickserv on matrix.org to see if it differs, but it seems like they don't use that anymore?

Can you confirm that the issue still applies, and the server you can reproduce this with?

jtagcat commented 4 months ago

I could reproduce with V{)0P#Nzsx.:#?Po&YeFYxLf"x<r%$oT*t{OdqmLRoa+=,,A7=%E%!FV+c4\HeVbsyq as the pass (changed it as a workaround).

jtagcat commented 4 months ago

Possible dupe of #442