Move to a knock model for joining IRC rooms.

matrix-org / matrix-appservice-irc

Node.js IRC bridge for Matrix

Apache License 2.0

460 stars 151 forks source link

Move to a knock model for joining IRC rooms. #1637

Open Half-Shot opened 1 year ago

Half-Shot commented 1 year ago

We currently work off a model where Matrix users join a room, then join the IRC channel. If they cannot join the channel, they are kicked. This presents a problem in the sense that:

They get brief access to history while this is in effect.
If the kick is slow to land, the user may be under the impression they were briefly joined to IRC.
It presents a poor UX, as the user feels like they've been kicked for behavioural problems rather than technical.

Mikaela commented 1 year ago

What does knock mean in this context? Do you mean the join rule introduced in room version 7 that only Nheko supports?

Ref: https://github.com/vector-im/element-meta/issues/43#issuecomment-1028271724

Half-Shot commented 1 year ago

Yes, knocking as in the join rule for rooms.

And yeah, we'd want wider client support. My primary fear is there isn't a sensible fallback, so clients will naturally fail to handle rooms if we make them all knock-y.

EDIT: Should say, haven't looked into knock_restricted yet. (Which wouldn't help us much).