search

matrix-org / matrix-appservice-irc

Node.js IRC bridge for Matrix
Apache License 2.0
460 stars 149 forks source link

Allow usernames to include more characters when using the `!username` command #1719

Closed progval closed 1 year ago

progval commented 1 year ago

Fixes https://github.com/matrix-org/matrix-appservice-irc/issues/1359 Supercedes https://github.com/matrix-org/matrix-appservice-irc/pull/1367 and https://github.com/matrix-org/matrix-appservice-irc/pull/1538, which were both too restrictive

This change allows for a much more permissive username when users are setting their own username.

progval commented 1 year ago

Signed-off-by: Valentin Lorentz \<progval plus matrixsignoff at progval dot net>

Half-Shot commented 1 year ago

Assuming tests pass this will be good enough for a merge.

Half-Shot commented 1 year ago

I'm happy with the contrib requirements and I believe docker builds are broken for non-collaborators atm (due to needing a login). @progval if you can make the lint happy I'll chuck this in the release tomorrow.

Half-Shot commented 1 year ago

:star: let's go!