search

matrix-org / matrix-appservice-irc

Node.js IRC bridge for Matrix
Apache License 2.0
460 stars 149 forks source link

Invisible messages when !storepass doesn't work #1747

Open Hi-Angel opened 1 year ago

Hi-Angel commented 1 year ago

There's a known issue #1483 where !storepass doesn't work on OFTC (and I will copy some of the information from there).

But there's also a different problem: after you used !storepass, not only you won't get any error, but if you then start sending messages to a channel required to log in, all messages will be invisible (to other users, not to you). So it would seem to you like you are participating in discussion, asking someone, replying to anyone… But in reality you are basically a ghost, which is pretty bad, because you basically spend your time for nothing. This is, like, the worst kind of bug of an interactive software that could happen, when you do something and not even aware that everything is ignored.

Steps to reproduce

  1. Make sure #1483 is not fixed
  2. Connect to OFTC. Register your nickname with NickServ.
  3. Tell @oftc-irc:​matrix.org to !storepass foo
  4. !reconnect
  5. !join #glibc
  6. Send a message

Expected

You'll receive an error saying you can't send messages

Actual

Everything goes smoothly, no errors, warnings, nothing that would alarm you.

Half-Shot commented 11 months ago

I think this is a mixed bug. We *do' report to the user via the admin room when a message has been explicitly rejected, so I can only imagine unregistered users are being silently ignored (and the irc client isn't told).

We can do better on the storepass thing not working.

Hi-Angel commented 11 months ago

so I can only imagine unregistered users are being silently ignored (and the irc client isn't told).

I presume you meant "non-logged in users"? If so, yes, that's the main problem: you think you are logged in and you send messages, but in reality you are not logged in (e.g. due to #1483) and all you messages are invisible.

funderscore1 commented 3 weeks ago

I think this is a mixed bug. We *do' report to the user via the admin room when a message has been explicitly rejected

Not on OFTC, no. For reference, a normal IRC client reports:

=!= #channel Cannot send to channel (You are not registered and verified.  '/msg NickServ help' to learn how to register and verify)

I opened a node-irc PR to try and solve this - https://github.com/matrix-org/node-irc/pull/114