matrix-org / matrix-appservice-irc

Node.js IRC bridge for Matrix
Apache License 2.0
460 stars 149 forks source link

Fix e2e error flakiness #1803

Closed Half-Shot closed 2 months ago

Half-Shot commented 2 months ago

Fixes #1802

This tackles this from two different directions. First: we now clean up a test's dependencies in series rather than parallel, which makes it error a bit less. Second, we send a message after reconnection and await this message. The reason is that currently the test will finish execution before it's had a chance to send the "Okay, I'm reconnecting you" Matrix message, which means the homeserver may be stopped before it has a chance to do so, and the wheels all come off.

Due to https://github.com/matrix-org/complement/issues/720, I've added a small retry loop for creating the homeserver deployment.

This hopefully should make our tests generally more reliable.