search

matrix-org / matrix-appservice-irc

Node.js IRC bridge for Matrix
Apache License 2.0
465 stars 151 forks source link

SASL support #470

Open Asara opened 7 years ago

Asara commented 7 years ago

Attempting to connect to a freenode from a AS running in AWS leads to this error:

{"command":"ERROR","rawCommand":"ERROR","commandType":"normal","args":["Closing Link: ec2-34-192-170-23.compute-1.amazonaws.com (SASL access only)"]}

Edit: Should probably just rename this to a feature request asking for SASL support in reality. Please feel free to do so if that is the case! :)

Mikaela commented 7 years ago

SASL specifications:

I think the issue would be better named as SASL PLAIN support for now and possibly later have separate issue for SASL EXTERNAL (aka/or CertFP (https://github.com/matrix-org/matrix-appservice-irc/issues/459)) and I recommend my recommendation on ignoring ECDSA-NIST256p-CHALLENGE from https://github.com/matrix-org/matrix-appservice-irc/issues/82#issuecomment-257782905 because of https://github.com/znc/znc/issues/746#issuecomment-119274435.

henk717 commented 7 years ago

!storepass is currently not supported on the Rizon bridge. Rizon lacks PASS support, this can be solved by implementing this feature request. SASL PLAIN is supported alongside EXTERNAL on there IRC network.

Half-Shot commented 6 years ago

Worth pointing out tthe upstream library supports this! It just needs careful integration.

Half-Shot commented 6 years ago

SASL PLAIN is now supported.

Asara commented 5 years ago

Is it possible to re-open this issue? I would say that https://github.com/matrix-org/matrix-appservice-irc/issues/689 still being an issue means that SASL support isn't really baked in yet.

Mikaela commented 5 years ago

@Half-Shot I would also request reopening this issue until users can actually use SASL to login. I think it would be more clear for majority of users for this to be open than pointing to https://github.com/matrix-org/matrix-appservice-irc/issues/673.

Half-Shot commented 5 years ago

Right yes. This needs #673 and #689 to be completed in order to close it.

thiras commented 4 years ago

Still waiting for it to start the migration to the matrix. Is there any ETA?

Mikaela commented 3 years ago

I think this is required for most (if not even all) Oragono Ergo deployments due to its integrated bouncer and force-nick-equals-account.

poVoq commented 1 year ago

Any news on this? Also SASL for the Matrixbot seems to fail when the IRC network (like Ergo.chat based ones) only supports real SASL login and not the fallback via server password it seems.

Edit: actually Ergo does support this, not sure why it still fails.

Edit: I set the bridge to force SASL and the bot still fails to use the SASL account on my Ergo IRC network and rather switches to an unregistered alt-nick. Something about the way this bridge does SASL is not standard conformant it seems.

Edit: So... apparently it works for user accounts but not the bridge bot...