search

matrix-org / matrix-appservice-irc

Node.js IRC bridge for Matrix
Apache License 2.0
462 stars 151 forks source link

Send avatars to IRC when requested #843

Open SoniEx2 opened 4 years ago

SoniEx2 commented 4 years ago

There should be a CTCP AVATAR that sends out the HTTPS link of the Matrix avatar.

>>> CTCP AVATAR
<<< NCTCP AVATAR https://...

And for room-specific avatars:

>>> CTCP AVATAR #foo
<<< NCTCP AVATAR https://... #foo

(>>> CTCP indicates an incoming CTCP request, <<< NCTCP indicates an outgoing CTCP response.)

This is particularly useful for moderating matrix-bridged rooms from the IRC side.

Half-Shot commented 4 years ago

This looks to be KVIRC specific rather than a standard feature, so I'm reluctant to support it.

SoniEx2 commented 4 years ago

KVIrc doesn't even support this actually. it's for ops and hand-crafted CTCP messages and stuff instead.

KlaasT commented 4 years ago

Afaik KVIrc does support CTCP. I use it to transfer my Avatar to other KVIrc users on the channel.

But yes it is something KVIrc specific.

Edit: I have to correct myself. I think IRC Cloud integrated this as well. At least I read it somewhere. It shouldn't be too hard to implement this and would give some users a bit more avatar comfort ;-)

SoniEx2 commented 4 years ago

KVIrc uses hidden color codes tho. and it doesn't support per-channel/room avatar. I want something that's more useful for ops than KVIrc users. there would be no automatic CTCPs being sent anywhere with my proposal.

SoniEx2 commented 4 years ago

this is just a way to query additional metadata on matrix users. metadata which is already exposed on the matrix side. (ideally we'd have CTCPs for all the relevant metadata we can bridge over. and it'd be one-way only (bridge to IRC) so the bridge isn't constantly spamming IRC users with CTCPs.)

Half-Shot commented 4 years ago

Edit: I have to correct myself. I think IRC Cloud integrated this as well. At least I read it somewhere. It shouldn't be too hard to implement this and would give some users a bit more avatar comfort ;-)

Irc Cloud use the IRCv3.2 METADATA command which is slightly more standardized but supporting v3 is a bit outside of scope atm, since most irc servers do not.

SoniEx2 commented 4 years ago

I could argue all day about ircv3 metadata being unsuitable for 99.9% of use-cases, but I think the most relevant point here is that it doesn't and cannot support per-room avatars. (I suggest taking a look at the issues in one of my repos for other real-life use-cases that are incompatible with it.)

Half-Shot commented 4 years ago

I think this is unlikely to be something to be taken up by myself as a thing to work on as we don't have a lot of demand for this from users, and the avatar space is fragmented between CTCPs and IRCV3).

That being said, I'm open to reviewing PRs that will add support for this.