search

matrix-org / matrix-appservice-irc

Node.js IRC bridge for Matrix
Apache License 2.0
465 stars 150 forks source link

Allow users to disable autopastebin at their own risk through feature settings #885

Open Half-Shot opened 4 years ago

Half-Shot commented 4 years ago

While we absolutely do not want to open the floodgates to spam, there are legitimate reasons to disable the pastebin for some folks. We can allow them to do this, at the risk of finding themselves banned from channels. This can be implemented via the feature flag.

Mikaela commented 4 years ago

Could this also become a flag for channel moderators/operators? I think it could be helpful for some that are mostly at Matrix or which owners/moderators are mostly positive with Matrix and at times get grumpiness from IRC users for the horrible pastebinning that at times makes IRC pings disappear.

If yes, maybe it could be mentioned in the help text that generally voicing Matrix users let them through some internal IRCd spam protections more easily?

Arceliar commented 4 years ago

Could this also become a flag for channel moderators/operators? I think it could be helpful for some that are mostly at Matrix or which owners/moderators are mostly positive with Matrix and at times get grumpiness from IRC users for the horrible pastebinning that at times makes IRC pings disappear.

If yes, maybe it could be mentioned in the help text that generally voicing Matrix users let them through some internal IRCd spam protections more easily?

Seconding this. Generalizing it a bit, maybe there could be some (configurable?) threshold where messages longer than N lines are pastebinned, but anything shorter is sent as multiple 1-line IRC messages? quoted replies are often 2 lines, so it would be nice if those could go through without pastebinning, but i'd feel differently about 200-line code dumps...

joepie91 commented 4 years ago

@Mikeale: I think it could be helpful for some that are mostly at Matrix or which owners/moderators are mostly positive with Matrix and at times get grumpiness from IRC users for the horrible pastebinning that at times makes IRC pings disappear.

As far as I've seen, highlights are generally at the start of a message - so changing the auto-pastebin message format to include the first line of the paste before the URL to the rest, would likely also address this issue.

If that doesn't work reliably enough, it would also be possible for the bridge to try and detect highlights throughout the message (as it knows what other users exist in the room/channel), and ensure that they are included in the autopastebin message.

That having been said, I do agree that it's useful to have this as a channel preference setting as well, to save IRC ops work.

@Arceliar: Seconding this. Generalizing it a bit, maybe there could be some (configurable?) threshold where messages longer than N lines are pastebinned, but anything shorter is sent as multiple 1-line IRC messages?

This is already how it works today. I think the threshold is at 3 lines or so by default?