search

matrix-org / matrix-appservice-slack

A Matrix <--> Slack bridge
Apache License 2.0
275 stars 72 forks source link

A pills mention immediately followed by any character (other than `:`) does not get converted to a slack mention #318

Open Cadair opened 4 years ago

Cadair commented 4 years ago

I assume there is something broken in the regex which means it needs a space after it. This is frustrating as it's the way riot-web tab completes.

auscompgeek commented 4 years ago

Seems like it should accept any word boundary instead.

https://github.com/matrix-org/matrix-appservice-slack/blob/f9b7feced8168b8ca11f254de6d3b3439d7547d1/src/substitutions.ts#L151-L153

auscompgeek commented 4 years ago

This was fixed by #320, I guess?

Cadair commented 4 years ago

This is still present with any character following the pill i.e. <pill>, <pill> which is super annoying.