fix ICE detrickling - Githubissues

matrix-org / matrix-appservice-verto

A Matrix <--> Verto bridge, designed for conferencing

Apache License 2.0

16 stars 7 forks source link

fix ICE detrickling #2

Closed ara4n closed 8 years ago

ara4n commented 8 years ago

Handle out-of-order candidates, and to ensure we have sufficient candidates before proceeding with the call.

This hasn't been at all tested (even to compile) yet, as I'm expecting to fiddle with it on production first. Before I do that, though, I wanted to get review of the general fix here.

kegsay commented 8 years ago

Aside from type coercion and a tiny amount of extra prose, this LGTM!

ara4n commented 8 years ago

@Kegsay - thanks for the review; have addressed and fixed a bunch of other stuff too. still not tested or even run though, so please ignore stupid thinkos. PTAL

kegsay commented 8 years ago

Looking good.

ara4n commented 8 years ago

this actually works now so i'm gonna merge it.