Fix not being able to DM users with non-ascii usernames

matrix-org / matrix-bifrost

General purpose bridging with a variety of backends including libpurple and xmpp.js

Apache License 2.0

163 stars 31 forks source link

Fix not being able to DM users with non-ascii usernames #271

Open tadzik opened 3 years ago

tadzik commented 3 years ago

Remote usernames with multibyte characters in them currently get encoded into mxids in a way that may result in information loss (see https://github.com/matrix-org/matrix-appservice-bridge/issues/346).

This makes it impossible to reach some users by MXID alone, so this makes it lookup the MXID in the user store, which contains the original, unmangled username.

Fixes GH-268.

tadzik commented 3 years ago

The failing test doesn't look trivial. That should get fixed first.

Which test?

Neustradamus commented 2 years ago

@tadzik: Have you progressed on your PR about @jaller94 comment?

@Half-Shot: What do you think?